Skip to content

chore: Improve Transcript service call chain #34920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kodiakhq merged 6 commits into from
Jan 20, 2025
Merged

chore: Improve Transcript service call chain #34920

kodiakhq merged 6 commits into from
Jan 20, 2025

Conversation

@KevLehman
Copy link
Member

@KevLehman KevLehman commented Jan 9, 2025 •
edited
Loading

Proposed changes (including videos or screenshots)

Basically, previous call was meteor => transcript => queue => transcript. The first call from meteor to the transcript service could be omitted if we do the logic on meteor.

With the new changes, meteor is the one that decides if we call transcript directly (on sync calls, for tests) or if we queue the item (for regular work).

Changes should work and improve a bit whether you use microservices or not.

Issue(s)

https://rocketchat.atlassian.net/browse/CORE-920

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jan 9, 2025 •
edited
Loading

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Jan 9, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: bc5c621

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025 •
edited
Loading

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34920/

Built to branch gh-pages at 2025-01-20 15:39 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented Jan 9, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.19%. Comparing base (f323946) to head (bc5c621).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #34920      +/-   ##
===========================================
+ Coverage    59.17%   59.19%   +0.01%     
===========================================
  Files         2821     2820       -1     
  Lines        68140    67734     -406     
  Branches     15155    15085      -70     
===========================================
- Hits         40325    40092     -233     
+ Misses       24981    24820     -161     
+ Partials      2834     2822      -12
Flag Coverage Δ
unit 75.01% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@KevLehman KevLehman marked this pull request as ready for review January 9, 2025 16:19
@KevLehman KevLehman requested review from a team as code owners January 9, 2025 16:19
@KevLehman KevLehman added this to the 7.3.0 milestone Jan 9, 2025
MarcosSpessatto
MarcosSpessatto suggested changes Jan 9, 2025
View reviewed changes
MartinSchoeler
MartinSchoeler approved these changes Jan 20, 2025
View reviewed changes
Copy link
Member

@MartinSchoeler MartinSchoeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Symbolic OC review :)

@Harmeet221 Harmeet221 added the stat: QA assured Means it has been tested and approved by a company insider label Jan 20, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jan 20, 2025
@kodiakhq kodiakhq bot merged commit 1fb9f86 into develop Jan 20, 2025
49 checks passed
@kodiakhq kodiakhq bot deleted the chore/improve-service-flow branch January 20, 2025 16:36
juliajforesti pushed a commit that referenced this pull request Jan 28, 2025
@KevLehman @juliajforesti
chore: Improve Transcript service call chain (#34920)
b04b65d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MartinSchoeler MartinSchoeler MartinSchoeler approved these changes

+1 more reviewer

@MarcosSpessatto MarcosSpessatto MarcosSpessatto approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Milestone

7.3.0

Development

Successfully merging this pull request may close these issues.

5 participants

@KevLehman @MarcosSpessatto @MartinSchoeler @Harmeet221